Reset placeholder display attribute instead of changing it to block #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which changed the original placeholder class
|
Thanks for this, @wwsno ! The PR looks good. Can you add a test for this behaviour, so we explicitly check the original |
|
What do you expect from a test for this? uiTreeNode seems completely untested and it seems rather non trivial to add a single test for this fix. |
Voles
pushed a commit
that referenced
this pull request
Nov 8, 2015
Reset placeholder display attribute instead of changing it to block
|
You're right, tests are important but it's not trivial to add them for this behaviour. There are other parts which are more important to get covered for now. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset placeholder css display attribute, so it resets to whatever the placeholder class display attribute was set to.
In case someone is using a custom placeholder class this can unexpectedly change the css, for example when display is set to 'block-inline';
Pull request #525 added this behavior.