Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent node being non-collapsable after drag-and-drop in-place #878

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

Nadya3910283-0192-0
Copy link
Contributor

Added isUiTreeRoot = false; in check if it or it's parents has a 'data-nodrag' attribute for preventing become item not selectable after clicking on this item.

Added isUiTreeRoot = false; in check if it or it's parents has a 'data-nodrag' attribute for preventing become item not clickable after clicking on this item twice.
@Voles
Copy link
Member

Voles commented Feb 12, 2017

@Nadya3910283-0192-0 @paulcalviere #891 trying to perform the same fix. I think the code of @paulcalviere provides a more robust fix, but @Nadya3910283-0192-0 has made the change on the right file.

Could any of you two create or update it's PR? Thanks in advance!

Changed according to the pull request angular-ui-tree#891
@Voles Voles changed the title Updated uiTreeNode.js. Prevent node being non-collapsable after drag-and-drop in-place Feb 16, 2017
@Voles Voles mentioned this pull request Feb 16, 2017
@Voles
Copy link
Member

Voles commented Feb 16, 2017

@Nadya3910283-0192-0 thanks for your fast reply! Merging now 🥇

@Voles Voles merged commit 39d69d2 into angular-ui-tree:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants