[CodeMirror] UI-Refresh, unit tests fix, and 3.02 update #412
Conversation
|
Very cool. So this is an alternative to #316? |
| scope.foo = 'bar'; | ||
| scope.$apply(); | ||
| $timeout.flush(); | ||
| expect($.trim(element.siblings().text())).toBe(scope.foo); |
There was a problem hiding this comment.
When I test locally this seems to be failing :(
|
Looks like travis only ran 1 test (need to open a bug on testacular about this). Go to travis, login with your github account, and in the dropdown menu of the build choose 'restart build'. Then scroll to the bottom of the build when it's done and confirm all tests ran. I don't get why when testacular does this and it drives me fucking nuts. |
|
K It was there since the 90th travis build (the one that changes the Testacular version from "~0.2.0" to "~0.4.0"). |
|
There are merge conflicts with master. Additionally, I am getting lots of wonderful problems with my own tests so I may have to let someone else handle this. Can you pull the latest ui/master version and push the conflict resolution for me? Perhaps I'm resolving things incorrectly. Also, I know there was an (unrelated) discussion about using elm.type vs elm.tagName.toLowerCase() but since type is always available for textarea and since this directive will never be used with any other DOM element, can you revert it back to using 'type'? Sorry for all the hassle lol. We are ALMOST THERE! |
|
I tried to rebase my repo on angular-ui/angular-ui remote master branch . Is it better ? |
Hi @ProLoser
Inspired by your last commits #316 I fixed my commented unit tests, added your ui-refresh and updated the CodeMirror version to 3.02.