Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(timepicker): width of hours/minutes input fields in template #1198

Closed
tschach opened this issue Oct 23, 2013 · 3 comments
Closed

fix(timepicker): width of hours/minutes input fields in template #1198

tschach opened this issue Oct 23, 2013 · 3 comments

Comments

@tschach
Copy link

tschach commented Oct 23, 2013

The width of the hours/minutes input fields in the timepicker template is currently set by a "span1" in the class attribute:

<input type="text" ng-model="hours" ng-change="updateHours()" class="span1 text-center" ng-mousewheel="incrementHours()" ng-readonly="readonlyInput" maxlength="2">
...
<input type="text" ng-model="minutes" ng-change="updateMinutes()" class="span1 text-center" ng-readonly="readonlyInput" maxlength="2">

This causes a faulty width setting when timepicker is placed inside a "row-fluid".

I suggest to change this to "input-block-level":

<input type="text" ng-model="hours" ng-change="updateHours()" class="input-block-level text-center" ng-mousewheel="incrementHours()" ng-readonly="readonlyInput" maxlength="2">
...
<input type="text" ng-model="minutes" ng-change="updateMinutes()" class="input-block-level text-center" ng-readonly="readonlyInput" maxlength="2">
@pkozlowski-opensource
Copy link
Member

@tschach would you be up to providing a pull request for this change?

@lazychino
Copy link
Contributor

@tschach I'm currently fixing timepicker look with BS3, I noticed what you are saying and will try your fix

@bekos
Copy link
Contributor

bekos commented Jan 11, 2014

@tschach After @lazychino changes the width of inputs are set fixed to 50px. I think your problem does not occur anymore.

If not feel free to re-open.

@bekos bekos closed this as completed Jan 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants