This repository has been archived by the owner on May 29, 2019. It is now read-only.

Modal: pressing escape key should give a dismiss reason #1956

Closed

tkrotoff opened this issue Mar 19, 2014 · 1 comment

Contributor

tkrotoff commented Mar 19, 2014

Small remark.

At modal.js#L203 no reason is given:

$modalStack.dismiss(modal.key);

It should be symmetric with modal.js#L313:

$modalStack.dismiss(modal.key, 'backdrop click');

Contributor

bekos commented Mar 21, 2014

@tkrotoff Nice catch. What about a PR? It should be relatively easy.

tkrotoff mentioned this issue

fix(modal): give a reason of rejection when escape key pressed #1991

Closed

bekos closed this as completed in

cb31b87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.