Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

No indication that a bower install in not enough #2622

Closed
stephaneeybert opened this issue Aug 22, 2014 · 10 comments
Closed

No indication that a bower install in not enough #2622

stephaneeybert opened this issue Aug 22, 2014 · 10 comments

Comments

@stephaneeybert
Copy link

It would be nice if there was a note explicitly stating that the css file needs to be added in the index.html file. The bower install does not take care of this. The bower install only inserts the js include statement.

@cheshire137
Copy link

The bower install I just did didn't insert anything into my HTML file, actually, and I can't find the JS files mentioned in the README that I need to manually include. From the bower install output:

bower angular-ui-bootstrap#*     invalid-meta angular-ui-bootstrap is missing "main" entry in bower.json
bower angular-ui-bootstrap#*     invalid-meta angular-ui-bootstrap is missing "ignore" entry in bower.json

My Grunt output:

angular-ui-bootstrap was not injected in your file.
Please go take a look in "/Users/me/code/my-app/bower_components/angular-ui-bootstrap" for the file you need, then manually include it in your file.

@stephaneeybert
Copy link
Author

I'm surprised you did a bower angular-ui-bootstrap. Personally I did a bower angular-bootstrap. Was I wrong ? After manually adding the .css file in my index.html file it works fine though.

@stephaneeybert
Copy link
Author

My bower.json file only contains the following bootstrap entry: "angular-bootstrap": "~0.11.0"

Should that be enough ?

@pkozlowski-opensource
Copy link
Member

Installation instructions are here: https://github.com/angular-ui/bootstrap#installation and those clearly mention bower command: bower install angular-bootstrap.

As for dependencies on CSS - the trouble is that bootstrap doesn't publish CSS alone as a separate artefact. So adding dependencies on the whole bootstrap package would drag all the Bootstrap's JavaScript and jQuery dependency and it would be even more confusing for the users as this project doesn't require any of the mentioned JavaScript dependencies.

@stephaneeybert @moneypenny if you guys can think of the doc update that could make it clear I would be happy to merge a PR. Thnx!

@stephaneeybert
Copy link
Author

Thanks for the clarification. The "As for..." paragraph would be cool on the installation page.

@stephaneeybert
Copy link
Author

Sorry, my Git experience is limited, I wonder what a PR is for example.

@pkozlowski-opensource
Copy link
Member

@stephaneeybert
Copy link
Author

I'm coming back to this, stumbling on the missing css resource, biting me. I can't see anything about it in the doc now.

@stephaneeybert
Copy link
Author

What was needed was the following command:
bower install bootstrap -s
And adding the following statement in the app/index.html file:

@goldcaddy77
Copy link
Contributor

@stephaneeybert - You actually need to bower install angular-bootstrap. I've put in a PR for this: #3521. Then you just need to include a script tag referencing "angular-bootstrap/ui-bootstrap-tpls.js"

@karianna karianna added this to the 0.13.0 milestone Apr 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants