This repository has been archived by the owner on May 29, 2019. It is now read-only.
Fixed #3143: fixed functionality of 'show-weeks' attribute on datepicker popup #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/datepicker/datepicker.js
|
@ankit5990 Merge conflict, can you rebase and push please. |
|
ya sure lemme fix that. Its a pretty old PR so conflicts must have crept in... |
|
Hi @karianna , |
|
Needs a test. |
| @@ -529,6 +529,11 @@ function ($compile, $parse, $document, $position, dateFilter, dateParser, datepi | |||
| if (attrs.dateDisabled) { | |||
| datepickerEl.attr('date-disabled', 'dateDisabled({ date: date, mode: mode })'); | |||
| } | |||
|
|
|||
| if(attrs.showWeeks) { | |||
| datepickerEl.attr('show-weeks',attrs.showWeeks); | |||
There was a problem hiding this comment.
space after , and above, space before (;
|
@chrisirhc, yes I'll make the corrections and submit the code again with the required tests. Gimme a couple of days. I'm not very proficient with testing framework... |
|
HI @chrisirhc, I have added the tests for the bug fix change. Please review. :) |
|
Squashed and merged. Also cleaned up trailing spaces. Thank you! |
|
Thanks for merging the fix @chrisirhc :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show weeks attribute was not working on datepicker popup.
Even when its value is set to 'false', the calender still shows weeks as per issue #3143.
The fixed version can be seen on plunkr
http://plnkr.co/edit/MJE44Blp7D2gIKWBOuwv?p=preview