This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): keyboard navigation #3212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yarl - Thanks for the PR - are you also able to add some test(s) around it? |
|
+1 |
| @@ -90,6 +91,27 @@ angular.module('ui.bootstrap.dropdown', []) | |||
| self.toggleElement[0].focus(); | |||
| } | |||
| }; | |||
|
|
|||
| scope.selectOption = function( evt ) { | |||
| var elems = angular.element(self.$element).find('.dropdown-menu a'); | |||
There was a problem hiding this comment.
It would be better to create a directive where when a value is true, then it focuses on the element.
|
As mentioned, this is in need of tests currently. |
|
Have a PR that adds this functionality. Started with yarl's fix but made it an optional flag, added some tests, and removed the apparent dependency on jQuery.
|
This was referenced May 18, 2015
bleggett
added a commit
to bleggett/bootstrap
that referenced
this pull request
Jun 3, 2015
fix(dropdown): Fixed indexing corner cases and filter key events. fix(dropdown): Try using document.bind instead fix(dropdown): Add optional attrib for keyboard-nav. fix(dropdown): Dedup code and handle differences if dropdown-menu used fix(dropdown): Fix focus issue and add more tests fix(dropdown): Update docs with example fix(dropdown): Revert accidental change to misc/demo/index.html fix(dropdown): Revert accidental indent changes to dropdown demo.html feat(dropdown): Add keynav support for dropdown menus (angular-ui#1228 and angular-ui#3212)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to use up and down arrows to navigate through list.
Fixes #1228