Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Accordion: is-disabled doesn't disable <accordion-heading /> #3233

Closed
mikolus opened this issue Jan 28, 2015 · 2 comments
Closed

Accordion: is-disabled doesn't disable <accordion-heading /> #3233

mikolus opened this issue Jan 28, 2015 · 2 comments

Comments

@mikolus
Copy link

mikolus commented Jan 28, 2015

Hi,
If you use "is-disabled" attribute on "accordion-group" with header as an attribute, everything works fine, "text-muted" class is added correctly.
But if you use tag, panel is still disabled, but the "text-muted" class is not added to the header.
Here is plunker:
http://plnkr.co/edit/n5LxEAeq5lyS5St6ndYr?p=preview

@rvanbaalen
Copy link
Contributor

This looks like a valid bug to me. Thanks for the very clear plunkr however you should use at least ui-bootstrap v0.12.1 and the latest Angular 1.2.x or Angular 1.3.x when demonstrating an issue.

I updated the plunkr and the bug can still be reproduced.

Here's an updated plunkr with the current master branch in ui-bootstrap-0.13.0-snapshot.js.

http://plnkr.co/edit/PjU6pmO1JU3xJlhxwN18?p=preview

@rvanbaalen rvanbaalen self-assigned this Apr 29, 2015
@rvanbaalen
Copy link
Contributor

I've also implemented a fix in the plunkr I just have to create a PR and write some tests for it now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants