This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(timepicker): move render logic to formatter #3427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,10 @@ angular.module('ui.bootstrap.timepicker', []) | |||
| ngModelCtrl = ngModelCtrl_; | |||
| ngModelCtrl.$render = this.render; | |||
|
|
|||
| ngModelCtrl.$formatters.unshift(function (modelValue) { | |||
| return (modelValue) ? new Date( modelValue ) : null; | |||
There was a problem hiding this comment.
Extra parentheses around the first modelValue
|
LGTM (only a style comment above). This resolves the issue ? I thought it had something to do with the input fields' type . |
- Moves render logic converting model values into date or null object into a formatter, which allows the render function to more correctly render using the viewValue - remove parentheses as per CR
wesleycho
force-pushed
the
fix/timepicker-formatting
branch
from
b89cd2a
to
2962a2d
Compare
|
It fixes the issue I think due to the |
|
Note: this PR also would close out #2069. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working Plunker here.
Fixes #3160 properly.