This repository has been archived by the owner on May 29, 2019. It is now read-only.
[Rating] Add titles for each stars #3621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lepit31 - The existing tests fail and we'd also like to see some new tests for this please :-). |
|
Fix the compilation bug This is my first git commit , sorry for the annoyance. |
|
No problem man. Appreciate the input. Everybody has got to start somewhere. |
| @@ -16,6 +16,10 @@ Rating directive that will take care of visualising a star rating bar. | |||
| _(Defaults: false)_ : | |||
| Prevent user's interaction. | |||
|
|
|||
| * `titles` | |||
| _(Defaults: ["bad","poor","regular","good","gorgeous"])_ : | |||
There was a problem hiding this comment.
Add spaces after each comma
| it('should return the custom title for each star', function() { | ||
| element = $compile('<rating ng-model="rate" titles="[44,45,46]"></rating>')($rootScope); | ||
| $rootScope.$digest(); | ||
| expect(getTitles()).toEqual(['44','45','46','4','5']); |
|
I spent some time refactoring the work & cleaning up the history just now - I changed the default values to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an attribute "titles" to set a custom title for each star by it position on array.
if the index of the star is greater than the titles array length return the index +1 of the star
Add a default value ["bad","poor","regular","good","gorgeous"]