This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): IE throws exceptions on body.activeElement.focus #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@tompi Thanks for the PR! Can you please add tests that cover your newly added code? |
|
👍 |
|
Thanks @tompi. Will review this later. |
|
This looks like a legitimate IE bug, as explained here. |
|
LGTM |
|
Just spent a day trying to nail this issue till found this. Please somebody make a new release with this fix!!! |
|
what have happened to this, why this PR was not merged? is this fixed already? |
|
It is already fixed @raftalks - take a look at the commit that closed this PR. |
|
@wesleycho Thanks. Just seen the changelog as well. 👯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3639