fix(datepicker): Don't parse the date twice

[realityking]

Fixes #3644, #3617

Potentially fixes #3643 as well, but I haven't tested that one yet.

Unit tests are missing, as I'm at a loss how to test these issues with karma. I'd appreciate some pointers in this regard. If it's fine to add protractor tests, I'd be happy to do so.

[kelvinatorr]

Works for me. Thanks!

[rvanbaalen]

Looks good and seems to be fixing some problems. Thanks for the PR! Will look into this soon to merge it.

[rvanbaalen]

@realityking Can you please add some tests for this?

[realityking]

@rvanbaalen Just to clarify, these tests would need protractor. Is that ok?

[rvanbaalen]

My bad. Now I see your comment about Karma tests. Was running an hour of slightly brainless PR and Issue triaging 😉

[realityking]

No problem, but I still don't have an answer ;) Are protactor tests fine?

[morgenes]

+1

[wesleycho]

This change would have an effect on HTML5 date inputs I believe, since the $viewChangeListener is the only callback that gets fired that parses the date input.

Can you produce a Plunker with an example of this in action for that situation?

[Blackbaud-PatrickOFriel]

Any word on the status of this PR?

[realityking]

I haven't had time to set up protractor tests, so at least that's still open.

I'd be great if someone could create the test mentioned by @wesleycho as I'm pretty short on time right now.

[almeidap]

I can confirm that this fixes some parsing and validation issues (particularly #1289), specially when manually changing the date.

For those using Bower who would like a hotfix, you may fetch AngularUI from here (minified version not updated): https://github.com/almeidap/angular-ui-bootstrap