This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): Captures focus in both directions - using tab & shift-tab #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will be in conflict with PR 3653. |
Tobino
force-pushed
the
a11y-tabbing-modal
branch
from
612759f
to
5ae356f
Compare
|
I'm feeling this should be closed in favour of #3653. But I'm not sure. Therefore, I leave this open with a 'needs: review' label. |
|
This is a lot of overriding of the tab behavior. Is the focusin handler mentioned in my comment #738 (comment) inadequate? |
|
I can remove some part if you want, depend on level of a11y you want. This directive is the angular version of bootstrap and bootstrap-accessibility-plugin with support of multiple modals. PS: Boostrap doesn't support multiple modals. |
paulorbpacheco
added a commit
to pdsoftplan/bootstrap
that referenced
this pull request
Jul 23, 2015
…h directions with tab or shift+tab. Refs: angular-ui#738, angular-ui#3689
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new directive to enforceFocus inside Modal.
This directive works with multiple modal, everything is tested except shift-tab because of karma.
I could test it with protrator.
I also refactor modalOpener.Focus without change in Spec.
fixes #738