Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Alert always shows close button #3848

Closed
flosky opened this issue Jun 24, 2015 · 5 comments
Closed

Alert always shows close button #3848

flosky opened this issue Jun 24, 2015 · 5 comments

Comments

@flosky
Copy link

flosky commented Jun 24, 2015

The alert directive always shows the close button ('x'), even if no close attribute is present.
This behaviour only occurs when using Angular.js v. 1.4.1. With version 1.4.0 everything is Ok.

To reproduce:
Use Angular.js v. 1.4.1 and use alert directive without 'close' attribute.

@antoinepairet
Copy link

Could you setup a plunkr please? thx

@rvanbaalen
Copy link
Contributor

We don't officially support Angular 1.4 yet so it is possible that some bugs occur. In the meanwhile, it helps if you provide a plunkr like @antoinepairet asked.

@flosky
Copy link
Author

flosky commented Jun 25, 2015

@wesleycho
Copy link
Contributor

This should be an easy fix on your side via CSS.

However, this does appear to be a bug in Angular 1.4 though.

@wesleycho
Copy link
Contributor

Linking a version of the Plunker based off of current master here for reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants