Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Datepicker today option is enabled if today's date is outside of max-date/min-date range #3988

Closed
JamesM123 opened this issue Jul 22, 2015 · 3 comments

Comments

@JamesM123
Copy link

The button to select Today in the datepicker is enabled and works even if today's date is outside of the valid max-date/min-date range.

I would imagine that if today's date falls outside the valid range of dates, then the today button should be hidden or disabled.

screen shot 2015-07-22 at 11 34 43

@wesleycho
Copy link
Contributor

Given that the min-date and max-date are observable, this should likely use either ng-show/ng-hide or ng-if. I would imagine that the max-date and min-date would change relatively infrequently, so I think an ng-if would be ok.

@wesleycho
Copy link
Contributor

Hmm, thinking about this more, I think a disabled would be more appropriate, perhaps with ng-disabled - this shouldn't be a difficult feature to implement if you want to open a PR.

@wesleycho
Copy link
Contributor

Please do not do a +1, it does not offer any useful signal.

@wesleycho wesleycho modified the milestones: 0.13.4 (Performance), Backlog Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants