This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(buttons): respect disabled attribute #4026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure disabled attribute is respected due to a change in Bootstrap 3.3.5 CSS
wesleycho
force-pushed
the
fix/bootstrap-3.3.5-button
branch
from
32c347a
to
7a1bc7a
Compare
| @@ -24,6 +24,10 @@ angular.module('ui.bootstrap.buttons', []) | |||
|
|
|||
| //ui->model | |||
| element.bind(buttonsCtrl.toggleEvent, function () { | |||
| if ('disabled' in attrs) { | |||
| return; | |||
There was a problem hiding this comment.
Is this the preferred syntax over if(attrs.disabled) which dropwdownToggle and tab directives use?
There was a problem hiding this comment.
The issue is Angular 1.4 - it turns out that attrs.disabled is undefined there, but the key is present.
There was a problem hiding this comment.
In the Tabs component, this should be fine - the only way there would be a problem is if the disabled attribute is used instead of disable, which is deprecated use.
For the dropdown toggle, I opened #4033
There was a problem hiding this comment.
Update: Looks like the dropdown works perfectly fine in 1.4
There was a problem hiding this comment.
Tabs look fine too.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plunker in action here.
This fixes #4013