This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): add $animateCss support
#4121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for `$animateCss`
wesleycho
force-pushed
the
fix/modal-animateCss
branch
from
0d5e619
to
46f120d
Compare
|
I updated the Plunker, with usage from the snapshot version of Angular, due to a major ngAnimate fix that is currently not released. This is still currently broken in 1.4.3, but only with the indicators and controls being missing. That part will be fixed with the release of 1.4.4. |
|
LGTM |
2 tasks
|
FYI you can use |
|
I should have checked the docs...I never knew that existed - thanks for that tidbit, I will refactor that now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$animateCssThe carousel change is to safely detect whether $animateCss is truly present (if the user is not using
ngAnimate, then this would throw an exception before this patch.The modal change is to correctly use
$animateCss- this can be observed in action here.I am currently still investigating #4119, and hopefully will be able to patch that up on top of this or as a part of this PR. These changes are not enough to fix the broken behavior, as can be seen here.