Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Customization of the carousel #4201

Closed
nirus opened this issue Aug 13, 2015 · 6 comments
Closed

Customization of the carousel #4201

nirus opened this issue Aug 13, 2015 · 6 comments

Comments

@nirus
Copy link

nirus commented Aug 13, 2015

Cannot access $scope.slides object inside carousel controller to customize the carousel template. The answer in the stackoverflow explains the scenario and possible work around.
Link: http://stackoverflow.com/a/31989387/1848109

Keep up the good work. Your library is awesome.

@wesleycho
Copy link
Contributor

It actually is exposed, via controllerAs - couldn't you use carousel.slides in the template, or does that not work?

@wesleycho
Copy link
Contributor

A Plunker would also be very helpful - a demonstration of the failure to access here would be a good starting point.

@nirus
Copy link
Author

nirus commented Aug 13, 2015

@wesleycho
Copy link
Contributor

I think I see now - the slides array is an array of the slide element $scope in the carousel controller.

Would allowing an optional binding to the slide directive accomplish what you want then, where the binding would allow binding the actual slide object on $scope?

@wesleycho wesleycho added this to the 0.13.x milestone Aug 13, 2015
@nirus
Copy link
Author

nirus commented Aug 13, 2015

Yes. Correct.This would allow the customization of the <li> elements as illustrated in the plunkr and also loop animation on the <li> tags when the slides changes.

@wesleycho
Copy link
Contributor

Alright, I'll have it implemented in the next couple of days.

@wesleycho wesleycho modified the milestones: 0.13.4 (Performance), 0.13.x Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants