Inconsistent newlines in the source files

[hlship]

Edittng the aggregated files (ui-bootstrap-0.3.0.js) you can see that there's been a mix of Mac/Unix and Windows editors; many lines end with a ^M (carriage return) character.

[pkozlowski-opensource]

OK, so standardizing things is good, no question about it. Now, we need to weight benefits with the workload.

To have consistent line endings in generated files we would have to:

• agree on line endings in our source files (I guess unix-style and enforce it). Or mess with git settings: https://help.github.com/articles/dealing-with-line-endings
• force Grunt.js to concatenate with a certain line ending (as described here: An option for line endings, don't enforce it gruntjs/grunt-contrib-concat#20)

@angular-ui/bootstrap what do you guys think? I'm really after standards and consistency but it shouldn't be just for sake of it, it must be helping the project. Personally I can work with any standard as loon it is agreed upon and automatically enforced so I don't have to waste brain cycles on those.

@hlship a question for you - why did you need to edit build files? Was it a case of monkey-patching?

[joshdmiller]

@pkozlowski-opensource There's a lot of inconsistency in our code, but I'm not convinced of the value of standardizing everything - at least not when balanced against the requisite work. I would rather focus of features and testing. That said, if someone wants to ensure Unix-style line endings automatically (like through one of your methods above) I have no problem with that.

[ajoslin]

+1 for the git option. We should be able to just put a .gitconfig file in the project with the following:

[core]
  autocrlf=input

[pkozlowski-opensource]

@ajoslin @joshdmiller so I had a close look into what is possible to be done automatically and it looks like we could get away with one setting in the git repo:

• http://timclem.wordpress.com/2012/03/01/mind-the-end-of-your-line/
• https://help.github.com/articles/dealing-with-line-endings#platform-all

plus configuring grunt merge tasks to use lf.

@angular-ui/bootstrap if no one objects against switching to lf I will prepare a PR for this. The downside is that we will have one commit that will touch many files and it will make merging PRs a bit harder...