This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(collapse): convert to use $animateCss
#4257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love to give you an answer, but it is still magic for me. Sometimes you need it, sometimes you don't. That is ngAnimate for you. |
|
Commenting that this should not be merged - ngAnimateMock changes in 1.4.5 means that this is broken. |
- Change to use `$animateCss` when available
wesleycho
force-pushed
the
feat/collapse-animateCss
branch
from
9d34501
to
a517b46
Compare
|
Going to need your assistance for this @Foxandxss - stuck on why these two tests don't pass :( . |
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
- Change to use `$animateCss` when available Closes angular-ui#4257
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$animateCsswhen availableI would like someone to pull this down and investigate the tests if possible - in particular, in the
should shrink accordingly when content size inside collapse decreasestest, if I do$animate.triggerCallbacks(), it causes the test to fail. Perhaps I am not understanding what is truly going on here with ngAnimate, since it seemed necessary in some of the other ones.