Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix issue 4298: Parent context keeps a reference on destroyed childre… #4299

Closed

Conversation

yoann-antoviaque
Copy link
Contributor

…n through closures

@pkozlowski-opensource
Copy link
Member

There are some style check failures, see: https://travis-ci.org/angular-ui/bootstrap/builds/77681435

@icfantv
Copy link
Contributor

icfantv commented Aug 28, 2015

@yoann-antoviaque is there a way to add a functional test for your code changes? if so, you'll need to do that as well.

@yoann-antoviaque
Copy link
Contributor Author

Well the only way i spotted it was through heap dumps therefore i do not see any way to test it automatically...

Le 28 août 2015 5:31 PM, Adam Gordon notifications@github.com a écrit :

@yoann-antoviaque is there a way to add a functional test for your code changes? if so, you'll need to do that as well.


Reply to this email directly or view it on GitHub.

@wesleycho wesleycho added this to the 0.13.4 (Performance) milestone Aug 28, 2015
@wesleycho
Copy link
Contributor

This is a very good catch - we should try to get this in as soon as possible.

Is it possible for you to write a test for this in the dropdown and typeahead components @yoann-antoviaque ?

@wesleycho
Copy link
Contributor

Actually, not sure we can test for this - this is good as is.

@wesleycho wesleycho closed this in 695db9d Aug 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants