This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): fix display when using with append-to-body #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to add `dropdown` class and open class to the `<body>` element BREAKING CHANGE: This differs from the existing behavior in that it no longer will toggle based on the existing `dropdown` directive element, but on the `body` element instead
|
Greenlit by @Foxandxss |
|
@wesleycho, is that label sufficient to ensure the breaking change makes it into the change log? |
|
@icfantv: yup |
|
coolness. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropdownclass and open class to the<body>elementBREAKING CHANGE: This differs from the existing behavior in that it no longer will toggle based on the existing
dropdowndirective element, but on thebodyelement insteadPlunker with fix in action here.
This fixes #4240.