fix(datepicker): ensure the original target is not in popup

[wesleycho]

• Ensure that the original event target is not a child of the popup element to avoid edge case where the datepicker closes on any click

This fixes #4314

[Foxandxss]

👍

[yjukaku]

This fix seems to have broken IE support. The popupEl seems to sometimes be a non-element node - IE doesn't support the contains method on non-element nodes, so this crashes.

[wesleycho]

@yjukaku can you try the change I just pushed up 65814f1 and let me know if that change fixes the issue?

[yjukaku]

@wesleycho Nope, doesn't seem to work.

Take a look at this Plunkr:
http://plnkr.co/edit/IlH0Y4CuhbAkL8mbthmT

This doesn't reference the master branch of the repo, but if you place a breakpoint on the http://angular-ui.github.io/bootstrap/ui-bootstrap-tpls-0.13.4.js at line 1851 you can see that the popupEl is actually pointing at a ng-if comment. Replacing popupEl with $popup doesn't seem to make a difference ($popup just points to the ng-if comment but wrapped in a jQuery object).

[yjukaku]

@wesleycho Any thoughts on this?

Do you want me to send up a pull request that fixes it?

[wesleycho]

Sure - the issue to reference is #4411.