This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(progressbar): add aria-labelledby support
#4350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,7 @@ describe('progressbar directive', function() { | |||
| expect(bar.attr('aria-valuemax')).toBe('100'); | |||
| expect(bar.attr('aria-valuenow')).toBe('22'); | |||
| expect(bar.attr('aria-valuetext')).toBe('22%'); | |||
| expect(bar.attr('aria-labelledby')).toBe('foo'); | |||
There was a problem hiding this comment.
do we want a test case for when the title attribute is omitted? that the title is progressbar.
- Add `aria-labelledby` support for accessibility
wesleycho
force-pushed
the
feat/progress-accessibility
branch
from
a8bcb82
to
b36c06e
Compare
|
Updated as requested |
|
👍 |
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
- Add `aria-labelledby` support for accessibility Closes angular-ui#4350 Resolves angular-ui#4347
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-labelledbysupport for accessibilityThis resolves #4247.