This repository has been archived by the owner on May 29, 2019. It is now read-only.

Typeahead event listeners never removed #4632

Closed

oliversalzburg opened this issue Oct 15, 2015 · 1 comment

Labels

component: typeahead type: bug

Contributor

oliversalzburg commented Oct 15, 2015

http://plnkr.co/edit/7KezbXxCsmx79oyDpux9?p=preview

When using typeahead-append-to-body='true', event listeners will be bound to window and body, these listeners are never unbound.

To showcase:

In the plunker, click the Open me! button.
Close the modal, by clicking Cancel.
Change the preview window body size by moving the splitter.
fireRecalculating will be called.

The text was updated successfully, but these errors were encountered:

icfantv added component: typeahead type: bug PRs plz! labels

Contributor

icfantv commented Oct 15, 2015

Yep. Looks like a bug. Good catch. Please feel free to submit a PR. Thanks.

oliversalzburg mentioned this issue

fix(typeahead): dangling event listeners #4636

Closed

icfantv removed the PRs plz! label

Foxandxss closed this as completed in

94fb282

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.