Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(tooltip): race condition when setting position #4765

Closed
wants to merge 1 commit into from
Closed

fix(tooltip): race condition when setting position #4765

wants to merge 1 commit into from

Conversation

RobJacobs
Copy link
Contributor

A race condition could occur when there is an open delay that
doesn't get cancelled after the transition delay resulting in
the position logic getting called. This will then try to set
the css of the tooltip after is has been destroyed in the
removeTooltip function.

Fixes #4757

A race condition could occur when there is an open delay that
doesn't get cancelled after the transition delay resulting in
the position logic getting called.  This will then try to set
the css of the tooltip after is has been destroyed in the
removeTooltip function.

Closes #4765
Fixes #4757
@wesleycho
Copy link
Contributor

LGTM

@RobJacobs RobJacobs closed this in 429ddc1 Oct 28, 2015
RobJacobs added a commit that referenced this pull request Oct 28, 2015
A race condition could occur when there is an open delay that
doesn't get cancelled after the transition delay resulting in
the position logic getting called.  This will then try to set
the css of the tooltip after is has been destroyed in the
removeTooltip function.

Closes #4765
Fixes #4757
@RobJacobs RobJacobs deleted the fix-tooltip-race branch November 3, 2015 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants