This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(typeahead): change to appendTo
#4797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
feat/typeahead-append-to
branch
from
8f6f39e
to
ba1b1d5
Compare
|
I am not sure if I understand that BC message, a bit complex. I would perhaps add what angular does. A before code and a after code. Other than that, fine for me. |
- Change signature to `appendTo`, which takes a value that evaluates to a DOM node for API consistency
BREAKING CHANGE: Usage before
```html
<div id="typeahead-container"></div>
<input typeahead="state for state in states | filter: $viewValue | limitTo: 8" typeahead-append-to-element-id="typeahead-container">
```
After
```html
<div id="typeahead-container"></div>
<input typeahead="state for state in states | filter: $viewValue | limitTo: 8" typeahead-append-to="typeaheadContainer">
```
```js
$scope.typeaheadContainer = angular.element(document.querySelector('#typeaheadContainer'));
```
wesleycho
force-pushed
the
feat/typeahead-append-to
branch
from
ba1b1d5
to
759cabe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appendTo, which takes a value that evaluates to a DOM node for API consistencyBREAKING CHANGE: This requires changing from using the string representation of the element id to select to passing in the element itself. A simple change on the user side would be to change it to a value on the element's parent $scope to a value that evaluates to the node, i.e.
angular.element($document[0].getElementById('elementId'))