Strange behaviour of uib-collapse inside ng-repeat

[BParnikel]

Faced with strange behaviour of uib-collapse inside ng-repeat with changing collection: animations calls with each collection update, despite the fact that uib-collapse is set to false;

See plunkr: http://plnkr.co/edit/rP1AlbLsi1qXuJOJL0D6?p=preview

[ghost]

Maybe related? #4848

[RobJacobs]

Closing as support question answered on SO, link

[BParnikel]

I got only a partial answer on SO about transition between primitives.
But what about first opening of uib-collapse="false" with animation? I suppose it shouldn't be happened, but it does...

[RobJacobs]

This is a result of the expand animation being run immediately in the link function. Adding the following code:

if (!scope.$eval(attrs.uibCollapse)) {
  element.addClass('in')
    .addClass('collapse')
    .css({height: 'auto'});
} 

at the top of the linking function seems to solve the problem. We should look at why the 'collapse' class is being removed in the expand function. We should be doing something like the collapse function is doing:

if (element.hasClass('collapse') && element.hasClass('in')) {
  return expandDone();
}

Updated plunk with code changes.

[BParnikel]

Thank you! Is there a chance that this fix will be included in next releases? I think changing of vendor sources is a bad practice :)

[wesleycho]

I wonder if this is related to all of our ngAnimate modal + collapse issues - can you check on whether the fix fixes those issues to @RobJacobs?

[RobJacobs]

@wesleycho Will do, wanted to get the positioning PR in first.

[wesleycho]

This is not related to the modal issues - that one turns out to be a gotcha with ng-app needing to be present on the body element or higher.

[wesleycho]

Actually...nevermind, I could be mistaken.

[wesleycho]

So to clarify why the collapse class is removed - Bootstrap uses the collapsing class to set the transition, and the in class to animate.

[BParnikel]

Great job, @wesleycho, thank you!