This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): alt-input-formats #4952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -811,6 +813,9 @@ function(scope, element, attrs, $compile, $parse, $document, $rootScope, $positi | |||
|
|
|||
| if (angular.isString(viewValue)) { | |||
| var date = dateParser.parse(viewValue, dateFormat, scope.date); | |||
| for(var i = 0; isNaN(date) && i < altInputFormats.length; i++) { | |||
There was a problem hiding this comment.
Would it make more sense to move the isNaN check to inside the loop after the dateParser is run? That way one can just break out of the loop if it is a valid date.
There was a problem hiding this comment.
OK. I plan to move the isNaN(date) to inside the loop.
| _(Default: [])_: | ||
| A list of alternate formats acceptable for manual entry. | ||
|
|
||
| ### Keyboard Support ###s |
There was a problem hiding this comment.
remove that extra s and lowercase that support (not sure why you even touched that anyway).
Also the [] on the default needs to be between backsticks.
davious
force-pushed
the
alt-input-formats
branch
from
1760c8d
to
7369d16
Compare
davious
added a commit
to davious/angular-ui-bootstrap
that referenced
this pull request
Nov 28, 2015
- Adds support for multiple input formats Closes angular-ui#4951 Closes angular-ui#4952
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4951