This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): ng-model-options: timezone #5062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davious
force-pushed
the
datepicker-ng-model-options
branch
3 times, most recently
from
a1c26a6
to
ef4189c
Compare
| @@ -100,6 +100,10 @@ The datepicker has 3 modes: | |||
| allowInvalid support. [More on ngModelOptions](https://docs.angularjs.org/api/ng/directive/ngModelOptions). | |||
|
|
|||
|
|
|||
| * `ng-model-options` | |||
| _(Default: {})_ - | |||
| Timezone support. [More on ngModelOptions](https://docs.angularjs.org/api/ng/directive/ngModelOptions). | |||
There was a problem hiding this comment.
This should be condensed with the ng-model-options block directly above, changing the allowInvalid and timezone mention to sub-bullet points.
davious
force-pushed
the
datepicker-ng-model-options
branch
from
ef4189c
to
30079ec
Compare
|
The dateparser additions will need unit tests. |
| @@ -571,6 +579,8 @@ function(scope, element, attrs, $compile, $parse, $document, $rootScope, $positi | |||
| if (datepickerPopupConfig.html5Types[attrs.type]) { | |||
| dateFormat = datepickerPopupConfig.html5Types[attrs.type]; | |||
| isHtml5DateInput = true; | |||
| ngModelOptions.timezoneHtml5 = ngModelOptions.timezone; | |||
There was a problem hiding this comment.
Is there a particular reason for splitting this out?
There was a problem hiding this comment.
This is a great question. Looking through the changes, the distinction seems superfluous. I forget why I made the distinction in the first place. Let me remove it.
|
I think this is close to done, just needs those tasks/questions to be answered and this should be good to merge. This is a lot cleaner than my own attempt at it. |
davious
force-pushed
the
datepicker-ng-model-options
branch
2 times, most recently
from
8348d8e
to
469477d
Compare
davious
force-pushed
the
datepicker-ng-model-options
branch
from
469477d
to
32071bb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4837
plunker http://plnkr.co/edit/eEAYYfDbEBz754iVUSYN?p=preview