feat(typeahead): add event object to on select callback #5165
Conversation
| @@ -202,7 +202,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap | |||
| return false; | |||
| }; | |||
|
|
|||
| var getMatchesAsync = function(inputValue) { | |||
| var getMatchesAsync = function(inputValue, evt) { | |||
There was a problem hiding this comment.
There are some calls to this function which do not seem to have an event object, such as when the typeahead directive inits.
Is it okay for the event object to be undefined in these cases? Any other suggestions in order to always have an event object?
There was a problem hiding this comment.
I think it is fine - only thing is to perhaps add a note in the documentation that this can be the case.
|
This LGTM, just need that one documentation update and this should be good. |
|
@wesleycho, thanks just updated the documentation. Just curious, how often do you release a new version? Do you see this getting added to a new stable version soon? I noticed some errors happening with typeahead in master, before this change was put in. Should I open a bug for it, or are things in master not yet released still under active development? |
|
If there is something wrong, open an issue with reproduction - we may be releasing tomorrow or Saturday, so if there is a real issue, the earlier we can see what is going on, the better |
|
@wesleycho, sounds good thanks. Created issue for it: #5167 |
It would be nice to have access to the event object in the typeahead on select callback.