This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tabs): revert template change #5262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2016
wesleycho
force-pushed
the
fix/tab-theme
branch
from
c49e9b4
to
55ba4a0
Compare
- Reverts template change to tab - Adds warning if one desires more complex HTML inside the tab BREAKING CHANGE: This undoes the prior change to the template using div elements. If one wishes to use div elements, one must override the template in one's app and provide the necessary CSS
wesleycho
force-pushed
the
fix/tab-theme
branch
from
55ba4a0
to
9d26f8b
Compare
|
LGTM after fixing tests. Do accordions have the same issue? |
|
Not really, although we could also do the same reverting on the accordion - the only thing we lose is any accessibility benefits and the cursor: pointer style. I'll open a PR for that. |
wesleycho
added a commit
to wesleycho/bootstrap
that referenced
this pull request
Jan 15, 2016
- Reverts template change to tab - Adds warning if one desires more complex HTML inside the tab BREAKING CHANGE: This undoes the prior change to the template using div elements. If one wishes to use div elements, one must override the template in one's app and provide the necessary CSS Closes angular-ui#5262 Fixes angular-ui#5254
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5254