This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): add datepickerOptions support #5340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wesleycho
commented
Jan 25, 2016
wesleycho
commented
- Add support for options object to concisely configure datepicker
wesleycho
force-pushed
the
feat/datepicker-options
branch
from
7bb2996
to
044dfbe
Compare
| self[key] = angular.isDefined($attrs[key]) ? $interpolate($attrs[key])($scope.$parent) : datepickerConfig[key]; | ||
| }); | ||
| if ($attrs.datepickerOptions) { | ||
| var datepickerOptions = $scope.$parent.$eval($attrs.datepickerOptions); |
There was a problem hiding this comment.
There is a potential flaw with this - if the user breaks the object reference, this will have the old reference cached.
There was a problem hiding this comment.
Can't we simply put in on the scope object? Extra watch but fixes that.
There was a problem hiding this comment.
Guess I could do datepickerOptions: '='
wesleycho
force-pushed
the
feat/datepicker-options
branch
from
044dfbe
to
c0bfb71
Compare
| @@ -12,6 +12,29 @@ The datepicker has 3 modes: | |||
|
|
|||
| ### uib-datepicker settings | |||
|
|
|||
| * `datepicker-options` | |||
There was a problem hiding this comment.
Alphabetical order please.
- Add support for options object to concisely configure datepicker
wesleycho
force-pushed
the
feat/datepicker-options
branch
from
c0bfb71
to
b7e7a14
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.