This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(progressbar): Progressbar doesnt modify object provided in max attribute #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinNuc
force-pushed
the
progress-bar-max-isolation
branch
from
dcaf8fd
to
80f829c
Compare
|
@MartinNuc, in general, it's a good idea to run the tests locally before committing anything to make sure you didn't mess something up...which is the case here. You can do that simply by running the |
MartinNuc
force-pushed
the
progress-bar-max-isolation
branch
from
80f829c
to
f6b1c3e
Compare
|
@icfantv My mistake. I had tests running localy but I made some changes after I made PR and forgot to run them again. Should be ok now. |
|
This is subtle - good catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #5373