This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): default to current date #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was weird code. LGTM. |
|
weird is one word to use, yes... |
wesleycho
force-pushed
the
fix/datepicker-popup-model
branch
from
75e7ae4
to
358ad50
Compare
wesleycho
added a commit
to wesleycho/bootstrap
that referenced
this pull request
Feb 2, 2016
- When model is empty, default to current date Closes angular-ui#5395 Fixes angular-ui#5190
wesleycho
force-pushed
the
fix/datepicker-popup-model
branch
from
358ad50
to
ca159c0
Compare
wesleycho
added a commit
to wesleycho/bootstrap
that referenced
this pull request
Feb 2, 2016
- When model is empty, default to current date Closes angular-ui#5395 Fixes angular-ui#5190
|
Looks like there are some unit tests that explicitly want this behavior - I need to do more research here. |
wesleycho
force-pushed
the
fix/datepicker-popup-model
branch
from
ca159c0
to
9f2412a
Compare
wesleycho
added a commit
to wesleycho/bootstrap
that referenced
this pull request
Feb 2, 2016
- When model is empty, default to current date Closes angular-ui#5395 Fixes angular-ui#5190
|
PR now good for review - turns out it was a different line that was the culprit. |
- When model is empty, default to current date Closes angular-ui#5395 Fixes angular-ui#5190
wesleycho
force-pushed
the
fix/datepicker-popup-model
branch
from
9f2412a
to
4b2ee0f
Compare
|
LGTM with the understanding that these attributes will be deprecated in favor of the config object. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in action here.
This fixes #5190.