This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): stop event bubbling from buttons #5400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop event bubbling from clicks in popup BREAKING CHANGE: This requires $event to be passed in the second argument of the select function and in the close argument for the popup template
wesleycho
force-pushed
the
fix/datepicker-propagation
branch
from
92ef8fa
to
f786368
Compare
| <button type="button" class="btn btn-sm btn-danger uib-clear" ng-click="select(null)">{{ getText('clear') }}</button> | ||
| </span> | ||
| <button type="button" class="btn btn-sm btn-success pull-right uib-close" ng-click="close()">{{ getText('close') }}</button> | ||
| <span class="btn-group pull-left"> |
There was a problem hiding this comment.
That was me fixing the indentation
There was a problem hiding this comment.
ooooooh. ok. i couldn't see it before. sorry.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in action here.
This fixes #5347