This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): implement auto position #5444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. |
Added popup-placement attribute that implements the auto position feature that exists in the tooltip directive. Accepts the same placement options as the tooltip. Closes #5444
|
This LGTM too |
|
Hm, I guess I forgot about the test part - how much testing does this need? We could perhaps test given certain CSS scenarios with regards to maybe display: block, position: relative/absolute, and floats. Tooltip/popover would need them too. |
|
@wesleycho I'm working on it still, will create another PR in the near future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added popup-placement attribute that implements the auto position
feature that exists in the tooltip directive. Accepts the same
placement options as the tooltip.
This plunk demos the feature.
I haven't added test for this as I'm not sure on what the best approach is for finding an elements position in a test and would like some guidance on that. The 2 minor changes in the readme.md is a result of my editor trimming trailing whitespace.
If this approach is acceptable, I plan on doing the same thing to the typeahead directive.