Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(tabs): update doc and fix tab demo #5575

Closed
wants to merge 1 commit into from
Closed

fix(tabs): update doc and fix tab demo #5575

wants to merge 1 commit into from

Conversation

icfantv
Copy link
Contributor

@icfantv icfantv commented Mar 2, 2016

  • update tab documentation to clarify proper use and intended behavior of the
    active attribute on both the tabset and tab directives.
  • fix the tab select buttons in the tab demo.

Fixes #5551

@icfantv
fix(tabs): update doc and fix tab demo
f51f8e0 
* update tab documentation to clarify proper use and intended behavior of the
  `active` attribute on both the `tabset` and `tab` directives.
* fix the tab select buttons in the tab demo.

Fixes angular-ui#5551
@icfantv icfantv added this to the 1.2.2 milestone Mar 2, 2016
@wesleycho
Copy link
Contributor

LGTM - that's a pretty bad mistake I did in the demo template.

@wesleycho wesleycho closed this in 9d74d6c Mar 2, 2016
@icfantv icfantv deleted the issue_5551 branch July 21, 2016 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: tab
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

active two-way data binding is broken in 1.2.0 and 1.2.1
2 participants
@icfantv @wesleycho