Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

On carousel hide prev when index is 0 and next when index is slides.length - 1 #5704

Closed
plondon opened this issue Mar 28, 2016 · 7 comments
Closed

Comments

@plondon
Copy link
Contributor

plondon commented Mar 28, 2016

It's unnecessary to have next and prev arrows if you can't go forward or back respectively and the carousel is not infinite.

@deeg
Copy link
Contributor

deeg commented Mar 28, 2016

Not sure if they should be hidden or maybe a class should be added to the arrow for the user to add disabled state or hide themselves through CSS.

@wesleycho, thoughts? Maybe this has come up before, and a decision was already made?

@icfantv
Copy link
Contributor

icfantv commented Mar 28, 2016

One can easily override this in the template directly. I'm ambivalent here on whether or not to do something in our library. @wesleycho, thoughts? I could go either way.

@wesleycho
Copy link
Contributor

Would be an easy feature to integrate I think - I'm ok with this.

@icfantv
Copy link
Contributor

icfantv commented Mar 28, 2016

Coolness, @plondon, pelase feel free to submit a PR w/ tests.

@deeg
Copy link
Contributor

deeg commented Mar 28, 2016

Just to be clear, would you guys rather a class be added where the user can decide what happens, or have it be in a disabled state, or remove it all together in this case?

@wesleycho
Copy link
Contributor

ng-show/ng-hide usage - a user can override the template if he/she wants otherwise.

@plondon
Copy link
Contributor Author

plondon commented Mar 29, 2016

#5708

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants