This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(modal): add resolve values to template #5857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, after the rebase |
|
Also @wesleycho, don't forget to add a BREAKING CHANGE comment to the body of the commit when merging. |
wesleycho
force-pushed
the
feat/resolve-in-template
branch
from
f547ad6
to
350bfa5
Compare
- Expose resolve in template as $resolve for those modals opened with a controller BREAKING CHANGE: Since this adds support for $resolve being exposed on $scope, it could potentially overwrite any pre-existing usage of it - this is an unlikely scenario, but marked as a breaking change in case this key is being used
wesleycho
force-pushed
the
feat/resolve-in-template
branch
from
350bfa5
to
b38c4f4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #5808, but may feature a minor breaking change - this could be fine to hold off until 2.0 if there are concerns about introducing a breaking change.