Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Update timepicker tabindices #5930

Closed
wants to merge 1 commit into from
Closed

Update timepicker tabindices #5930

wants to merge 1 commit into from

Conversation

flachware
Copy link
Contributor

Prevent focus on increment/decrement link buttons.

Prevent focus on increment/decrement link buttons.
@wesleycho
Copy link
Contributor

This has negative accessibility ramifications - what is the rationale for changing this?

@flachware
Copy link
Contributor Author

The intention of the proposed change is actually an improvement of accessibility: a native user agent input control of the type datetime-local or number does not expose the increment/decrement buttons to the accessibility API, those buttons do not receive the focus, that is.

While the increment/decrement buttons do have their point when the timepicker is used by a mouse, it is more convenient (and closer to HTML5 user agent controls) to skip them when the timepicker is used by a keyboard, avoiding unnecessary keystrokes in order to focus on the next input control. Using a keyboard, it seems more intuitive to simply enter numbers in an input control than to use the increment/decrement buttons.

@icfantv
Copy link
Contributor

icfantv commented Jun 13, 2016

@wesleycho, was @johanneskrtek's reasoning sound? if so, this will need tests before merging.

@wesleycho
Copy link
Contributor

Hm, I think this is actually ok - as long as the inputs are tabbable, this is ok.

It actually turns out that this is not properly testable just due to how tabindex works, so this is fine to merge as is.

@wesleycho wesleycho added this to the 2.0.0 milestone Jun 14, 2016
@wesleycho wesleycho closed this in 4e68778 Jun 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants