This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(modal): remove replace usage #5989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `replace: true` usage BREAKING CHANGE: This removes `replace: true` usage, causing some structural changes to the HTML - the major part here is that there is no more backdrop template, and the top level elements for the window/backdrop elements lose a little flexibility. See documentation examples for new structure.
|
@wesleycho Milestone 2.0.1 for this. |
|
? This is going to be in the upcoming 2.0.0 release. |
| 'template-url': modal.windowTemplateUrl, | ||
| 'window-class': modal.windowClass, |
There was a problem hiding this comment.
do we need to document that this attribute is removed as part of the breaking changes?
There was a problem hiding this comment.
The class is meant for adding to element the class, but that is now happening without needing a binding.
|
Save for potential docs comment, LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace: trueusageBREAKING CHANGE: This removes
replace: trueusage, causing some structural changes to the HTML - the major part here is that there is no more backdrop template, and the top level elements for the window/backdrop elements lose a little flexibility. See documentation examples for new structure.