uibDropdownConfig should be a .value() instead of a .constant() to allow decorating #6004

onlywei · 2016-06-14T19:09:31Z

I think it's pretty useful to allow people to customize this object via angular.module().decorator(), because maybe they want to use their own CSS classes. It should be an easy change, as I don't see uibDropdownConfig being injected anywhere other than a controller.

The text was updated successfully, but these errors were encountered:

wesleycho · 2016-06-14T21:07:50Z

One can use $provide.value to override it, but I'm actually not sure why they are .constants.

PRs welcome!

wesleycho added type: enhancement PRs plz! labels Jun 14, 2016

onlywei mentioned this issue Jun 14, 2016

feat(dropdown): use .value() for uibDropdownConfig #6006

Closed

wesleycho closed this as completed in 7457fb0 Jun 15, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uibDropdownConfig should be a .value() instead of a .constant() to allow decorating #6004

uibDropdownConfig should be a .value() instead of a .constant() to allow decorating #6004

onlywei commented Jun 14, 2016 •

edited

Loading

wesleycho commented Jun 14, 2016

uibDropdownConfig should be a .value() instead of a .constant() to allow decorating #6004

uibDropdownConfig should be a .value() instead of a .constant() to allow decorating #6004

Comments

onlywei commented Jun 14, 2016 • edited Loading

wesleycho commented Jun 14, 2016

onlywei commented Jun 14, 2016 •

edited

Loading