Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(modal): check for overflow hidden #6041

Merged
merged 1 commit into from
Jun 21, 2016
Merged

fix(modal): check for overflow hidden #6041

merged 1 commit into from
Jun 21, 2016

Conversation

RobJacobs
Copy link
Contributor

@RobJacobs RobJacobs commented Jun 21, 2016

Check if appendToElement has scrolling disabled before adding
the scrollbar padding.

Fixes #6037

Check if appendToElement has scrolling disabled before adding
the scrollbar padding.

Fixes #6037
Closes #6041
@icfantv
Copy link
Contributor

icfantv commented Jun 21, 2016

LGTM

@RobJacobs RobJacobs merged commit 433e536 into angular-ui:master Jun 21, 2016
@RobJacobs RobJacobs deleted the fix-modal branch June 21, 2016 19:58
@phazei
Copy link

phazei commented Nov 16, 2018

This "fix" actually breaks the padding added in every other case. It only checks the elements parent is scrollable, but the way it does the check, via visibility, fails for the body tag, since overflow is always 'visible' but it still produces scrollbars. I'm not familiar with any case where the element isn't appended to the body, so I don't know what happens there, but in the default case, this breaks generall use so should be rolled back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants