This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): avoid focus toggle element after dropdown is closed #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't understand this when I first looked at this, but the explanation is very good - thank you for this PR, this does sound like a good fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a bug:
As you can see in this code, it will call "closeDropdown" every time a click event:
Add I added the selection code for this function to avoid useless call:
As you can see in line 108, it will always focus on the toggle element whenever you click if we do not check the open status.
Thanks,
Alex