New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename or condense paging/pagination and tutorials 214 and 215 #2106
Comments
+1 |
Hi I am trying to use the paging stuff shown on the tutorial page but it appears that ui.grid.paging is not available yet in 3.0.0-rc.16 is this correct? |
@wgorder: when it works on the tutorial page it should also work for you. The plunker also works (Note: it works! I didn't say that it is good-looking :) ) Maybe you should post your code on stackoverflow?! |
@nabinca The module is defined in src/features/paging/js/ui-grid-paging.js in the master branch. What I am saying is that if you pull in 3.0.0-rc.16 from bower you get a single ui-grid.js file. And the ui.grid.paging module is not defined in there anywhere. This leads me to believe that this feature is not yet available in the latest release that can be obtained from bower. See here: |
The two modules are doing more or less the same. While "paging" provides pagination controls, "pagination" provides a public API so the pagination controls may be implemented externally. If that API would be moved to paging, you could probably drop the pagination module. Do you want me to investigate that and work out a PR? If yes, should the combined module be called "paging" or "pagination"? |
Yes, I think that would be useful. I'd call it pagination personally, not sure if others have a different opinion. |
+1 |
+1 |
I am currently using an unstable version of ui-grid and it has the paging module included. Personally, I prefer paging over pagination since much of the work is already done for you. One good thing about the current paging module, sorting works over the entire collection, not just for what's currently being displayed. Filtering, on the other hand, works on page data only. |
Completed. |
Thanks, @PaulL1. But is pagination a function only in the unstable version? |
Potentially so, yes. Sent from my iPad
|
Any chance, we can get a new release soon? |
Refer #2545 |
I see. Replace "release" with "release candidate" in my question. ;-) |
The next release candidate we're aiming for having all the hi-pri bugs fixed. We're close, but there are a few that still need doing: https://github.com/angular-ui/ng-grid/issues?q=is%3Aopen+is%3Aissue+label%3A%22Hi-Pri+Bug%22 |
So now there's two feature modules, "paging" and "pagination". That's going to be really confusing for our users.
Can these be combined into one? Or at least renamed if they accomplish two separate things?
The text was updated successfully, but these errors were encountered: