Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or condense paging/pagination and tutorials 214 and 215 #2106

Closed
c0bra opened this issue Nov 14, 2014 · 16 comments
Closed

Rename or condense paging/pagination and tutorials 214 and 215 #2106

c0bra opened this issue Nov 14, 2014 · 16 comments
Milestone

Comments

@c0bra
Copy link
Contributor

c0bra commented Nov 14, 2014

So now there's two feature modules, "paging" and "pagination". That's going to be really confusing for our users.

Can these be combined into one? Or at least renamed if they accomplish two separate things?

@c0bra c0bra added this to the 3.0 milestone Nov 14, 2014
@bhochberger
Copy link

+1
Here is the first user confused about that. I use the pagination for client-side paging. However, I tried to turn off pagination for one table in my App, but gridOptions.enablePagination=false doesn't seem to work.
Should I switch to paging ?

@wgorder
Copy link
Contributor

wgorder commented Nov 17, 2014

Hi I am trying to use the paging stuff shown on the tutorial page but it appears that ui.grid.paging is not available yet in 3.0.0-rc.16 is this correct?

@bhochberger
Copy link

@wgorder: when it works on the tutorial page it should also work for you. The plunker also works (Note: it works! I didn't say that it is good-looking :) ) Maybe you should post your code on stackoverflow?!

@wgorder
Copy link
Contributor

wgorder commented Nov 18, 2014

@nabinca

The module is defined in src/features/paging/js/ui-grid-paging.js in the master branch. What I am saying is that if you pull in 3.0.0-rc.16 from bower you get a single ui-grid.js file. And the ui.grid.paging module is not defined in there anywhere. This leads me to believe that this feature is not yet available in the latest release that can be obtained from bower.

See here:
https://github.com/angular-ui/ui-grid.info/tree/v3.0.0-rc.16/release/3.0.0-rc.16

@derrabus
Copy link
Contributor

The two modules are doing more or less the same. While "paging" provides pagination controls, "pagination" provides a public API so the pagination controls may be implemented externally. If that API would be moved to paging, you could probably drop the pagination module.

Do you want me to investigate that and work out a PR? If yes, should the combined module be called "paging" or "pagination"?

@PaulL1
Copy link
Contributor

PaulL1 commented Nov 19, 2014

Yes, I think that would be useful. I'd call it pagination personally, not sure if others have a different opinion.

@geekuillaume
Copy link

+1
I've just tried to implement my own pagination controls with an external pagination and it's really confusing. If I understood right, it's not possible at the moment to use the pagination API with the paging module, right ?

@delijah
Copy link

delijah commented Dec 8, 2014

+1

@bamab
Copy link

bamab commented Dec 8, 2014

I am currently using an unstable version of ui-grid and it has the paging module included. Personally, I prefer paging over pagination since much of the work is already done for you. One good thing about the current paging module, sorting works over the entire collection, not just for what's currently being displayed. Filtering, on the other hand, works on page data only.

@PaulL1
Copy link
Contributor

PaulL1 commented Jan 14, 2015

Completed.

@PaulL1 PaulL1 closed this as completed Jan 14, 2015
@blaiseliu
Copy link

Thanks, @PaulL1. But is pagination a function only in the unstable version?

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 3, 2015

Potentially so, yes.

Sent from my iPad

On 4 Feb 2015, at 5:56 am, Blaise Liu notifications@github.com wrote:

Thanks, @PaulL1. But is pagination a function only in the unstable version?


Reply to this email directly or view it on GitHub.

@derrabus
Copy link
Contributor

derrabus commented Feb 4, 2015

Any chance, we can get a new release soon?

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 4, 2015

Refer #2545

@derrabus
Copy link
Contributor

derrabus commented Feb 5, 2015

I see. Replace "release" with "release candidate" in my question. ;-)

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 5, 2015

The next release candidate we're aiming for having all the hi-pri bugs fixed. We're close, but there are a few that still need doing: https://github.com/angular-ui/ng-grid/issues?q=is%3Aopen+is%3Aissue+label%3A%22Hi-Pri+Bug%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants