Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete shim for $routeProvider backcomp #17

Closed
timkindberg opened this issue Feb 14, 2013 · 3 comments
Closed

Complete shim for $routeProvider backcomp #17

timkindberg opened this issue Feb 14, 2013 · 3 comments
Assignees

Comments

@timkindberg
Copy link
Contributor

The shim to implement the $routeProvider API on top of $stateProvider is mostly there:

  • copy over the unit tests from AngularJS and see what's missing to implement that API fully
  • maybe also try some existing Angular samples that use $routeProvider and see if they still work when running on the $stateProvider implementation.
@ghost ghost assigned ksperling Feb 14, 2013
@0x-r4bbit
Copy link
Contributor

So there should be a backward compatibility to $routeProvider? Kinda confuses me, 'cause README says it isn't the goal to make ui-router backward compatible (which of course doesn't mean that it's bad to have it).

@ksperling
Copy link
Contributor

Well, $state itself won't be backwards compatible with $route, but I'd like to have a little separate compatibility layer that can be shipped as a separate JS file / separate Angular module that does provide backwards compatibility.

At the moment the build process bundles it into the same JS file, but it's a separate module, so there is no runtime cost if the compatibility layer isn't used.

@nateabele
Copy link
Contributor

Closing this, since we're dropping BC with ngRoute.

@christopherthielen christopherthielen removed this from the 1.5.0 milestone Nov 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants