Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Breaking Change in 0.2.16 #2528

Closed
abhishekbhardwaj opened this issue Feb 5, 2016 · 2 comments
Closed

Minor Breaking Change in 0.2.16 #2528

abhishekbhardwaj opened this issue Feb 5, 2016 · 2 comments
Milestone

Comments

@abhishekbhardwaj
Copy link

Talking specifically about the bug fix in the $urlRouter code in 0.2.16:

Sort URL rules by specificity. Potential minor BC if apps were relying on rule registration order.

One of my application expects the states to be in a certain order I think? - (because I have 2 states for one url - 1 for authenticated users and 1 for unauthenticated users).

This is what should happen - if user goes to url:

  1. If unauthenticated, taken to state 1.
  2. If authenticated, taken to state 2.

Order the states are registered in:

  1. State 1
  2. State 2

Now what happens is that it works perfectly fine on Chrome, but on Firefox it never goes to state 1 but keeps redirecting to state 2, which essentially redirects the user again to a login screen.

On moving state 2 above state 1 in the registration order: it works on Firefox as expected but doesn't on Chrome.

Reverting to 0.2.15 fixed it for me but I'd like to upgrade. Any help or pointers would be appreciated!

@christopherthielen
Copy link
Contributor

On moving state 2 above state 1 in the registration order: it works on Firefox as expected but doesn't on Chrome.

Sorry about that. We're reverting that BC. Wait for 0.2.18 which will not sort your routes. dupe #2501

@abhishekbhardwaj
Copy link
Author

@christopherthielen Thanks a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants