Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Back-Compat) uiRouteProvider Routing #4

Closed
1 of 9 tasks
lrlopez opened this issue Jan 25, 2013 · 4 comments
Closed
1 of 9 tasks

(Back-Compat) uiRouteProvider Routing #4

lrlopez opened this issue Jan 25, 2013 · 4 comments
Labels

Comments

@lrlopez
Copy link

lrlopez commented Jan 25, 2013

Discussion on how enhance the default route provider with hierarchical routes in a backward compatible way.

Task list:

  • Duplicate the relevant code and test cases and just renaming the route service and the ngView directive.
  • Agree on a syntax to specify subroutes (nothing about smart reloading of subviews yet).
  • Add tests & make it work! (or viceversa, whatever we decide).
  • Discuss and agree on a intelligent way of updating or refreshing subviews.
  • Add tests that cover dynamic updating of subviews.
  • Enhance the route syntax (optional params, constraints, regexp, etc). At this point we should already agreed on this via the relevant issue thread).
  • Add test that cover the new syntax.
  • RFC?
  • Make a Pull Request to the AngularJS official repository.

Requirements extracted from the wiki and #1:

  • Implementation should be backward compatible with the actual routing system.
  • Implementation should be just one module.
  • We shouldn't override the original $routeProvider service nor the ngView directive. Let's just use uiRouteProvider and uiView instead (or whatever you want).
  • When designing how nested routing works
    • Subview naming should be optional if there is only one in that nesting level.
    • Subrouter are specified using nested objects inside the top level route param object.
    • At first, when a route changes all its subroutes get reloaded. We will add conditional refreshing/reloading/persistence/whatever later.
@lrlopez
Copy link
Author

lrlopez commented Jan 27, 2013

A new branch has been created to work on this: https://github.com/angular-ui/router/tree/ui-route-provider

It still needs some additional items to automate testing, does anyone volunteer?

@ProLoser
Copy link
Member

Would copying the stuff from AngularUI and setting up Travis not work?

@lrlopez
Copy link
Author

lrlopez commented Jan 29, 2013

Let me try...

@timkindberg
Copy link
Contributor

Closing because we are moving forward with @ksperling implementation, if you need to bring any issues from this discussion over to the new implementation please make a new issue. If you do bring over any of these issues, try to separate them into smallest chunks as possible per issue thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants